[CI] Remove unused variables and cleanup #16233
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
mrodm
commented
Dec 3, 2025
Comment on lines
-48
to
-53
| cleanup() { | ||
| echo "Deleting temporary files..." | ||
| rm -rf ${WORKSPACE}/${TMP_FOLDER_TEMPLATE_BASE}.* | ||
| echo "Done." | ||
| } | ||
|
|
Collaborator
Author
There was a problem hiding this comment.
Currently, there is no folder created with mktemp with those variables as a template.
So I think this cleanup function can be deleted.
mrodm
commented
Dec 3, 2025
Comment on lines
-28
to
-29
| export TMP_FOLDER_TEMPLATE_BASE="tmp.${REPO_NAME}" | ||
| export TMP_FOLDER_TEMPLATE="${TMP_FOLDER_TEMPLATE_BASE}.XXXXXXXXX" |
Collaborator
Author
There was a problem hiding this comment.
These were used in the past to create temporal folders to store the google_credentials.json file. But this was migrated in favor of using GCP OIDC (#13856)
This reverts commit 6656ead.
2 tasks
💔 Build Failed
Failed CI StepsHistory
cc @mrodm |
🚀 Benchmarks reportPackage
|
| Data stream | Previous EPS | New EPS | Diff (%) | Result |
|---|---|---|---|---|
incident |
1067.24 | 857.49 | -209.75 (-19.65%) | 💔 |
vulnerability |
10204.08 | 8223.68 | -1980.4 (-19.41%) | 💔 |
Package o365 👍(1) 💚(0) 💔(1)
Expand to view
| Data stream | Previous EPS | New EPS | Diff (%) | Result |
|---|---|---|---|---|
audit |
2159.83 | 1569.86 | -589.97 (-27.32%) | 💔 |
To see the full report comment with /test benchmark fullreport
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed commit message
Removed unused variables in Buildkite hooks.
The variables
TMP_FOLDER_TEMPLATEandTMP_FOLDER_TEMPLATE_BASEwere used before migrating to GCP OIDC #13856Tested failure in post-checkout hook: 6656ead
Checklist
changelog.ymlfile.Author's Checklist
TMP_FOLDER_TEMPLATEin.buildkite/scriptsfolderRelated issues